Skip to content

OSDOCS#14516: Removed tech preview for support router load secrets #92780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

OSDOCS#14516: Removed tech preview for support router load secrets #92780

merged 1 commit into from
May 13, 2025

Conversation

subhtk
Copy link
Contributor

@subhtk subhtk commented Apr 30, 2025 •
edited
Loading

Version(s): 4.19+

Issue: https://issues.redhat.com/browse/OSDOCS-14516

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 30, 2025 •
edited
Loading

🤖 Tue May 13 17:23:34 - Prow CI generated the docs preview:

https://92780--ocpdocs-pr.netlify.app/openshift-dedicated/latest/networking/routes/secured-routes.html
https://92780--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/routes/secured-routes.html
https://92780--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/cert_manager_operator/cert-manager-securing-routes.html
https://92780--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/routes/secured-routes.html

@subhtk
Copy link
Contributor Author

subhtk commented Apr 30, 2025

/cc @chiragkyal @lunarwhite

@openshift-ci openshift-ci bot requested review from chiragkyal and lunarwhite April 30, 2025 14:08
@chiragkyal
Copy link
Member

Will there be a separate PR for release notes update?

@chiragkyal
Copy link
Member

/hold
until 4.19 development branch cut happens.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2025
@subhtk
Copy link
Contributor Author

subhtk commented Apr 30, 2025

This PR will cover the additional request from https://issues.redhat.com/browse/OCPBUGS-34373.
[Quote] We need to update the https://docs.openshift.com/container-platform/4.17/networking/routes/secured-routes.html#nw-ingress-route-secret-load-external-cert_secured-routes documentation's Prerequisites section to reflect the updated permission requirement. A Note after the Prerequisites section should be good I think, with information like:-

- “create” permission is required on the routes/custom-host to set the `spec.tls.externalCertificate` field on route creation.

- Either “create” or “update” permission is required on the routes/custom-host to update `spec.tls.externalCertificate` field.

[Unquote]

@chiragkyal
Copy link
Member

This PR will cover the additional request from https://issues.redhat.com/browse/OCPBUGS-34373.

I think we would need a separate PR for that request, because this PR will land for 4.19+ whereas the bug was fixed in 4.18+

@subhtk
Copy link
Contributor Author

subhtk commented May 5, 2025 •
edited
Loading

Got it — this PR will just handle the tech preview removal. Here is the PR for the other request- #92978. Ptal. Thank you!

@chiragkyal
Copy link
Member

/unhold
/lgtm
/cc @lihongan

@openshift-ci openshift-ci bot requested a review from lihongan May 5, 2025 05:38
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2025
@lihongan
Copy link

lihongan commented May 6, 2025

LGTM.

And we need a separate PR to update 4.19 release notes.

@lunarwhite
Copy link
Member

We also need to remove the TP note from CM side: https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/security_and_compliance/cert-manager-operator-for-red-hat-openshift#cert-manager-securing-routes

^ This also applies to 4.19+, so it'd be fine to include it with this PR.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2025
@subhtk
Copy link
Contributor Author

subhtk commented May 8, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 8, 2025
@kowen-rh
Copy link
Contributor

kowen-rh commented May 8, 2025

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 8, 2025
kowen-rh
kowen-rh approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@kowen-rh kowen-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 8, 2025
@subhtk
Copy link
Contributor Author

subhtk commented May 11, 2025

Will there be a separate PR for release notes update?

Here is the release note PR- #93202 for the same update.

@chiragkyal
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
@subhtk
Copy link
Contributor Author

subhtk commented May 12, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 12, 2025
@subhtk
Copy link
Contributor Author

subhtk commented May 12, 2025

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label May 12, 2025
@subhtk
Copy link
Contributor Author

subhtk commented May 12, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 12, 2025
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 12, 2025
skopacz1
skopacz1 reviewed May 12, 2025
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question before this is ready to merge

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 13, 2025

New changes are detected. LGTM label has been removed.

skopacz1
skopacz1 reviewed May 13, 2025
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 13, 2025

@subhtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skopacz1
Copy link
Contributor

Looks good to merge!

@skopacz1 skopacz1 merged commit 63d7ede into openshift:main May 13, 2025
2 checks passed
@skopacz1
Copy link
Contributor

/cherrypick enterprise-4.19

@skopacz1 skopacz1 added this to the Planned for 4.19 GA milestone May 13, 2025
@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #93319

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 13, 2025
Merged
@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skopacz1 skopacz1 skopacz1 left review comments

@kowen-rh kowen-rh kowen-rh approved these changes

@chiragkyal chiragkyal Awaiting requested review from chiragkyal

@lunarwhite lunarwhite Awaiting requested review from lunarwhite

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@chiragkyal chiragkyal

Labels
branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.19 GA
Development

Successfully merging this pull request may close these issues.
8 participants
@subhtk @ocpdocs-previewbot @chiragkyal @lihongan @lunarwhite @kowen-rh @skopacz1 @openshift-cherrypick-robot